Skip to content

Commit c7d8ebc

Browse files
committed
Nits
1 parent 62e1048 commit c7d8ebc

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

packages/react-dom/src/server/ReactPartialRendererHooks.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ function areHookInputsEqual(
9393
);
9494
}
9595
}
96-
for (let i = 0; i < nextDeps.length; i++) {
96+
for (let i = 0; i < prevDeps.length && i < nextDeps.length; i++) {
9797
if (is(nextDeps[i], prevDeps[i])) {
9898
continue;
9999
}

packages/react-reconciler/src/ReactFiberHooks.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ function areHookInputsEqual(
161161
);
162162
}
163163
}
164-
for (let i = 0; i < nextDeps.length; i++) {
164+
for (let i = 0; i < prevDeps.length && i < nextDeps.length; i++) {
165165
if (is(nextDeps[i], prevDeps[i])) {
166166
continue;
167167
}

packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js

-1
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ describe('ReactHooks', () => {
453453
'Previous: [A, B]\n' +
454454
'Incoming: [A]\n',
455455
]);
456-
expect(ReactTestRenderer).toHaveYielded(['Did commit: A, B']);
457456
});
458457

459458
it('warns if switching from dependencies to no dependencies', () => {

0 commit comments

Comments
 (0)