Skip to content

Commit d069348

Browse files
committed
Move ReactServerSharedInternals on to ReactSharedInternalsServer
Really the top level secret export should just be forked into two different versions. This was just trying to move some earlier than others.
1 parent b88c7ba commit d069348

10 files changed

+49
-84
lines changed

packages/react-server-dom-turbopack/src/ReactFlightTurbopackNodeRegister.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ module.exports = function register() {
4444
}).body;
4545
} catch (x) {
4646
// eslint-disable-next-line react-internal/no-production-logging
47-
console.error('Error parsing %s %s', url, x.message);
47+
console['error']('Error parsing %s %s', url, x.message);
4848
return originalCompile.apply(this, arguments);
4949
}
5050

packages/react-server-dom-webpack/src/ReactFlightWebpackNodeRegister.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ module.exports = function register() {
4444
}).body;
4545
} catch (x) {
4646
// eslint-disable-next-line react-internal/no-production-logging
47-
console.error('Error parsing %s %s', url, x.message);
47+
console['error']('Error parsing %s %s', url, x.message);
4848
return originalCompile.apply(this, arguments);
4949
}
5050

packages/react-server/src/ReactFlightServer.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ import {
111111
import type {SharedStateServer} from 'react/src/ReactSharedInternalsServer';
112112
import ReactSharedInternalsImpl from 'shared/ReactSharedInternals';
113113
const ReactSharedInternals: SharedStateServer = (ReactSharedInternalsImpl: any);
114-
import ReactServerSharedInternals from './ReactServerSharedInternals';
115114
import isArray from 'shared/isArray';
116115
import getPrototypeOf from 'shared/getPrototypeOf';
117116
import binaryToComparableString from 'shared/binaryToComparableString';
@@ -307,7 +306,7 @@ const {
307306
TaintRegistryValues,
308307
TaintRegistryByteLengths,
309308
TaintRegistryPendingRequests,
310-
} = ReactServerSharedInternals;
309+
} = ReactSharedInternals;
311310

312311
function throwTaintViolation(message: string) {
313312
// eslint-disable-next-line react-internal/prod-error-codes

packages/react-server/src/ReactServerSharedInternals.js

-24
This file was deleted.

packages/react/src/ReactServer.experimental.js

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import './ReactFetch';
1212

1313
export {default as __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactSharedInternalsServer';
1414

15-
export {default as __SECRET_SERVER_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactServerSharedInternals';
16-
1715
import {forEach, map, count, toArray, only} from './ReactChildren';
1816
import {
1917
REACT_FRAGMENT_TYPE,

packages/react/src/ReactServer.js

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import './ReactFetch';
1212

1313
export {default as __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactSharedInternalsServer';
1414

15-
export {default as __SECRET_SERVER_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './ReactServerSharedInternals';
16-
1715
import {forEach, map, count, toArray, only} from './ReactChildren';
1816
import {
1917
REACT_FRAGMENT_TYPE,

packages/react/src/ReactServerSharedInternals.js

-44
This file was deleted.

packages/react/src/ReactSharedInternalsServer.js

+28-1
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,31 @@ import type {Dispatcher} from 'react-reconciler/src/ReactInternalTypes';
1111
import type {CacheDispatcher} from 'react-reconciler/src/ReactInternalTypes';
1212
import type {ReactComponentInfo} from 'shared/ReactTypes';
1313

14-
import {disableStringRefs} from 'shared/ReactFeatureFlags';
14+
import type {
15+
Reference,
16+
TaintEntry,
17+
RequestCleanupQueue,
18+
} from './ReactTaintRegistry';
19+
20+
import {
21+
TaintRegistryObjects,
22+
TaintRegistryValues,
23+
TaintRegistryByteLengths,
24+
TaintRegistryPendingRequests,
25+
} from './ReactTaintRegistry';
26+
27+
import {disableStringRefs, enableTaint} from 'shared/ReactFeatureFlags';
1528

1629
export type SharedStateServer = {
1730
H: null | Dispatcher, // ReactCurrentDispatcher for Hooks
1831
C: null | CacheDispatcher, // ReactCurrentCache for Cache
1932

33+
// enableTaint
34+
TaintRegistryObjects: WeakMap<Reference, string>,
35+
TaintRegistryValues: Map<string | bigint, TaintEntry>,
36+
TaintRegistryByteLengths: Set<number>,
37+
TaintRegistryPendingRequests: Set<RequestCleanupQueue>,
38+
2039
// DEV-only-ish
2140
owner: null | ReactComponentInfo, // ReactCurrentOwner is ReactComponentInfo in Flight, null in Fizz. Fiber/Fizz uses SharedStateClient.
2241

@@ -33,6 +52,14 @@ const ReactSharedInternals: SharedStateServer = ({
3352
C: null,
3453
}: any);
3554

55+
if (enableTaint) {
56+
ReactSharedInternals.TaintRegistryObjects = TaintRegistryObjects;
57+
ReactSharedInternals.TaintRegistryValues = TaintRegistryValues;
58+
ReactSharedInternals.TaintRegistryByteLengths = TaintRegistryByteLengths;
59+
ReactSharedInternals.TaintRegistryPendingRequests =
60+
TaintRegistryPendingRequests;
61+
}
62+
3663
if (__DEV__ || !disableStringRefs) {
3764
ReactSharedInternals.owner = null;
3865
}

packages/react/src/ReactTaint.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ import getPrototypeOf from 'shared/getPrototypeOf';
1313

1414
import binaryToComparableString from 'shared/binaryToComparableString';
1515

16-
import ReactServerSharedInternals from './ReactServerSharedInternals';
16+
import ReactSharedInternals from './ReactSharedInternalsServer';
1717
const {
1818
TaintRegistryObjects,
1919
TaintRegistryValues,
2020
TaintRegistryByteLengths,
2121
TaintRegistryPendingRequests,
22-
} = ReactServerSharedInternals;
22+
} = ReactSharedInternals;
2323

2424
interface Reference {}
2525

scripts/jest/setupHostConfigs.js

+16-5
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@ function mockReact() {
4646
);
4747
return jest.requireActual(resolvedEntryPoint);
4848
});
49+
// Make it possible to import this module inside
50+
// the React package itself.
51+
jest.mock('shared/ReactSharedInternals', () => {
52+
return jest.requireActual('react/src/ReactSharedInternalsClient');
53+
});
4954
}
5055

5156
// When we want to unmock React we really need to mock it again.
@@ -54,6 +59,10 @@ global.__unmockReact = mockReact;
5459
mockReact();
5560

5661
jest.mock('react/react.react-server', () => {
62+
// If we're requiring an RSC environment, use those internals instead.
63+
jest.mock('shared/ReactSharedInternals', () => {
64+
return jest.requireActual('react/src/ReactSharedInternalsServer');
65+
});
5766
const resolvedEntryPoint = resolveEntryFork(
5867
require.resolve('react/src/ReactServer'),
5968
global.__WWW__
@@ -161,11 +170,13 @@ inlinedHostConfigs.forEach(rendererInfo => {
161170
});
162171
});
163172

164-
// Make it possible to import this module inside
165-
// the React package itself.
166-
jest.mock('shared/ReactSharedInternals', () =>
167-
jest.requireActual('react/src/ReactSharedInternalsClient')
168-
);
173+
jest.mock('react-server/src/ReactFlightServer', () => {
174+
// If we're requiring an RSC environment, use those internals instead.
175+
jest.mock('shared/ReactSharedInternals', () => {
176+
return jest.requireActual('react/src/ReactSharedInternalsServer');
177+
});
178+
return jest.requireActual('react-server/src/ReactFlightServer');
179+
});
169180

170181
// Make it possible to import this module inside
171182
// the ReactDOM package itself.

0 commit comments

Comments
 (0)