Include Modes in the component stack #13240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSR test passes. The client one doesn't.
Merged
This was referenced Sep 7, 2018
41 tasks
This was referenced Nov 1, 2018
This was referenced Sep 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #13109.
Now that the component stack is always attached automatically, this seems like a low-effort way to know the mode without exposing more methods on the isomorphic frame module. This should allow us to parse the stack to determine whether we're in a strict root, and be helpful when debugging (e.g. "where does the strict/async mode start in my tree?").