Skip to content

[react-devtools-inline][4.22.0]: broken published package #22958

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
AviVahl opened this issue Dec 15, 2021 · 2 comments · Fixed by #22961
Closed

[react-devtools-inline][4.22.0]: broken published package #22958

AviVahl opened this issue Dec 15, 2021 · 2 comments · Fixed by #22961

Comments

@AviVahl
Copy link

AviVahl commented Dec 15, 2021

Steps To Reproduce

  1. install react-devtools-inline in a project that has react and react-is
  2. open node
  3. require('react-devtools-inline')
  4. See error:
Uncaught:
Error: Cannot find module '/Users/jstejada/code/jstejada-react/build/oss-experimental/react-is'
Require stack:
- /home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js
- <repl>
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.14 (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:1344:18)
    at __webpack_require__ (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:21:30)
    at Object.3 (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:5710:17)
    at __webpack_require__ (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:21:30)
    at Object.10 (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:495:64)
    at __webpack_require__ (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:21:30) 

The current behavior

Published package contains the following code:

module.exports = require("/Users/jstejada/code/jstejada-react/build/oss-experimental/react-is");
...
module.exports = require("/Users/jstejada/code/jstejada-react/build/oss-experimental/react");

The expected behavior

No absolute paths in bundle. successful evaluation.

@AviVahl AviVahl added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Dec 15, 2021
@bvaughn bvaughn added Component: Developer Tools Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Dec 15, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Dec 15, 2021

Looks like maybe a regression caused by #22813? Can you look into this @jstejada? I wonder if the fix in #22790 would have caused this regression too?

Edit: Looks like #22760 was what broke this. My bad.

@bvaughn
Copy link
Contributor

bvaughn commented Dec 15, 2021

Fix has been published as 4.22.1. Sorry again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants