-
Notifications
You must be signed in to change notification settings - Fork 48.4k
Text adjacent to radio button that is not wrapped in any tag results in a minified exception #6705
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
This is not enough information for this issue to be actionable. Can you reproduce the bug in a minimal repro/jsfiddle? |
@jineshshah36 If you put a breakpoint on the error you can usually quite easily see where the error is originating from and look up the actual error from the development build. |
There must be something outside of this causing the bug, I tried to reproduce in this JSFiddle and cannot. |
I think the determining factor will be what the value of |
No response from OP. |
Hi, sorry I was traveling and this got lost. Essentially, I'm having trouble figuring out a way to replicate this to you guys. The main issue is that the exception only occurs when minified and in production. So whenever I check the development version, there are no errors |
I did some digging and tried to follow @syranide advice. I am having a similar issue with an img tag and was able to trace it to this function
The line that is in the stacktrace is this one:
The |
So in dev mode it should throw an invariant violation exception with the message |
@jineshshah36 Can you please try to reproduce this with a version of React compiled from master? You can grab one from http://react.zpao.com/builds/master/latest/. |
Hey guys, so I found the culprit. I still don't quite understand why, but Cloudflare was causing the issues. Cloudflare was re-minifying my already minified script which was causing some sort of issue that lead to weird errors like this. Thanks for everyone's help, but everything looks to be working now. |
Thanks for following up. If you do figure out what Cloudflare might have been doing to break in such a way, let us know. We might want to work with them to ensure it doesn't happen to others. |
Potentially related to #5753 (comment) if you're mounting server-rendered markup. |
I'll investigate further to see if #5753 is related |
This:
<label><input type={'radio'} />{props.children}</label>
results in a minified exception that is nearly impossible to debug because it tells me to switch to development mode; however, I receive no errors in development mode.
This:
<label><input type={'radio'} /><div>{props.children}</div></label>
does not result in any errors.
I am not sure what the problem here is, but I just spent 6 hours trying to debug this issue, so I figured I should bring it to your attention.
The text was updated successfully, but these errors were encountered: