Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

sl pr submit doesn't use the bookmark name #970

Open
hakanalpaydd opened this issue Oct 22, 2024 · 1 comment
Open

sl pr submit doesn't use the bookmark name #970

hakanalpaydd opened this issue Oct 22, 2024 · 1 comment

Comments

@hakanalpaydd
Copy link

hakanalpaydd commented Oct 22, 2024 •
edited
Loading

Using VS Code Interactive Smartlog

  1. be checked out on master
  2. make changes
  3. Commit changes with some name
image
  1. Right click on the commit and create bookmark (to give it a branch name for when the PR is pushed to github)
image
  1. Observe bookmark name is added
image
  1. Submit for code review. This button runs sl pr submit
image
  1. Observe that bookmark (branch name) not used in PR
image

Is there a way to fix this? Either with commands or in the UI (ideally both)?
@Kimeiga Kimeiga mentioned this issue Oct 23, 2024
Closed
@gabemeola
Copy link

Related as this feature was added then removed: #772

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabemeola @hakanalpaydd