Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build error after PR #3665 #4303

Open
fwsGonzo opened this issue Feb 20, 2025 · 1 comment
Open

Build error after PR #3665 #4303

fwsGonzo opened this issue Feb 20, 2025 · 1 comment

Comments

@fwsGonzo
Copy link

fwsGonzo commented Feb 20, 2025

PR #3665 introduces a build error for me. I recently saw the release 1.5.7 improved performance and I wanted to check this out. Updating my submodule resulted in the error:

/usr/bin/ccache ... -O3 -o ext/zstd/build/cmake/lib/CMakeFiles/libzstd_static.dir/__/__/__/lib/decompress/huf_decompress_amd64.S.o -c ext/zstd/lib/decompress/huf_decompress_amd64.S
/usr/bin/ccache: invalid option -- 'D'

I bisected it to the aforementioned PR 3665.

The zstd project builds again by removing the if statement introduced in the PR. I don't have Xcode so I can't make a change that solves my Ubuntu ccache build issue as well as building on Xcode.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Feb 20, 2025

It would be great to have a test in CI able to reproduce this issue.
I've been trying to reproduce it on 2 different systems so far, and been unable to witness the same issue.
It seems tied to a specific way to compile the source code, more specifically the assembly source file.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants