Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Better document how to add new loaders after ejecting #1208

Closed
gaearon opened this issue Dec 8, 2016 · 3 comments
Closed

Better document how to add new loaders after ejecting #1208

gaearon opened this issue Dec 8, 2016 · 3 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Dec 8, 2016

The existing comment is too easy to miss.

See http://stackoverflow.com/questions/41042479/create-react-app-with-sass-not-loading-styles.

We need to make it more obvious.

@ro-savage
Copy link
Contributor

@gaearon - I have submitted PR #1499 to make the comment stand out more.

I have made the original comment stand out more with some spacing, and given a more practical example and have added a new comment to the end of the loaders array where a person would usually add a new loader to warn them to update the exclude list.

@ro-savage
Copy link
Contributor

New PR #1500 to fix noob mistakes and to get a nice round PR number.

@Timer Timer mentioned this issue Feb 8, 2017
@Timer Timer closed this as completed Feb 8, 2017
@Timer
Copy link
Contributor

Timer commented Feb 8, 2017

Resolved by #1500.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants