Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Webpack plugin to detect case mismatch in requires #266

Merged
merged 1 commit into from
Jul 29, 2016

Conversation

alexzherdev
Copy link
Contributor

@alexzherdev alexzherdev commented Jul 28, 2016

Addresses #240.
Plugin works as advertised, both with requires and imports.
I was not sure if we need this in prod, so only included in dev for now. Also, pinned the version as with other dependencies.
screen shot 2016-07-28 at 23 03 16

@ghost ghost added the CLA Signed label Jul 28, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 28, 2016

Can you assess the performance impact of this on recompiles?
You can import a large project into a create-react-app app, and see how much time it takes to save a file before and after this change.
We want to make sure it doesn’t slow down the rebuilds.

@alexzherdev
Copy link
Contributor Author

By importing do you mean creating a new app via create-react-app, and then just copying sources over?

@gaearon
Copy link
Contributor

gaearon commented Jul 28, 2016

Doesn’t really matter, I just want to check what happens when there are many modules.

@gaearon
Copy link
Contributor

gaearon commented Jul 29, 2016

(To be clear, what you suggested sounds like a good way, yes.)

@alexzherdev
Copy link
Contributor Author

I have a mid-size project handy (~10k lines), taking ~15s on the initial startup, recompiles take a fraction of a second with or without the plugin. I wonder if recompiles on a bigger project (like React at 50k lines) would be seriously slower, but it's hard to make a complex project compile without bringing in all the infrastructure.

@gaearon gaearon merged commit c7c319e into facebook:master Jul 29, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 29, 2016

Looking good, thank you.

@gaearon gaearon modified the milestones: 0.3.0, 0.2.1 Jul 29, 2016
@gaearon gaearon mentioned this pull request Aug 1, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants