Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the right and bottom padding of the error overlay #758

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 26, 2016

Minor CSS tweak to the error overlay: fix the right and bottom padding by adding box-sizing: border-box.

Before:
screen shot 2016-09-26 at 3 22 06

After:
screen shot 2016-09-26 at 3 22 38

@ghost ghost added the CLA Signed label Sep 26, 2016
@gaearon gaearon merged commit 7d0fd03 into facebook:master Sep 26, 2016
@gaearon gaearon added this to the 0.7.0 milestone Sep 26, 2016
kitze added a commit to kitze/custom-react-scripts that referenced this pull request Sep 27, 2016
…react-app

# By Ville Immonen (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  added link to better visualizing tool (facebook#764)
  Fix the right and bottom padding of the error overlay (facebook#758)
  Remove the `.` at the end of the init message (facebook#760)
  Bump recursive-readdir (facebook#756)
  Forked react-scripts should retain the binary name (facebook#754)
  Mention the npm bug in migration instructions
@gaearon gaearon modified the milestones: 0.6.1, 0.7.0 Sep 27, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2016

Should be out in 0.6.1.

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
…react-app

# By Ville Immonen (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  added link to better visualizing tool (facebook#764)
  Fix the right and bottom padding of the error overlay (facebook#758)
  Remove the `.` at the end of the init message (facebook#760)
  Bump recursive-readdir (facebook#756)
  Forked react-scripts should retain the binary name (facebook#754)
  Mention the npm bug in migration instructions
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants