fix(hash): Ensure hash is included when using hash history #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed so src/toUrl.js are now using history to create the href. In src/handlePress.js we remove the hash if it exists when creating an action with the url, this to find the right route.
|
Let me know if theres a need for documentation? Does the user need to do anything additional or is this one of those PRs that all under the hood? |
ScriptedAlchemy
approved these changes
Dec 15, 2018
|
There should be no need for any new documentation, it's as you say, under the hood. :) |
|
Automated release is on its way |
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed so src/toUrl.js are now using history to create the href. In src/handlePress.js we remove
the hash if it exists when creating an action with the url, this to find the right route.
Sorry for all the PR:s that I closed hehe.