Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use simplified modern user-agents #3323

Closed
matthewmayer opened this issue Dec 5, 2024 · 0 comments · Fixed by #3324
Closed

Use simplified modern user-agents #3323

matthewmayer opened this issue Dec 5, 2024 · 0 comments · Fixed by #3324
Assignees
@matthewmayer
Labels
c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module
Milestone
vAnytime

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented Dec 5, 2024 •
edited
Loading

The user-agent method uses lots of custom code. Additionally the browsers represented are very outdated (10 years old), e.g. there's no Edge, no mobile browsers, no bots.

Suggest to replace with a list of fake patterns instead in the base locale.

Followon from #1761
@matthewmayer matthewmayer self-assigned this Dec 5, 2024
@matthewmayer matthewmayer mentioned this issue Dec 5, 2024
Merged
@matthewmayer matthewmayer added c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module labels Dec 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@matthewmayer matthewmayer

Labels
c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

feat(internet): update to simplified modern user-agent list matthewmayer/faker
2 participants
@matthewmayer @ST-DDT