Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Faker::Internet.username and .email have no YARD docs #2243

Closed
connorshea opened this issue Jan 23, 2021 · 1 comment · Fixed by #2247
Closed

Faker::Internet.username and .email have no YARD docs #2243

connorshea opened this issue Jan 23, 2021 · 1 comment · Fixed by #2247
Labels
Chores 📘 Documentation

Comments

@connorshea
Copy link
Member

Describe the bug

There are no YARD docs on the username or email methods in Faker::Internet

To Reproduce

See

faker/lib/faker/default/internet.rb

Line 44 in 664cbaf

def username(legacy_specifier = NOT_GIVEN, legacy_separators = NOT_GIVEN, specifier: nil, separators: %w[. _])

Expected behavior

I expect there to be YARD docs.
@sudeeptarlekar
Copy link
Contributor

Will look into this

This was referenced Jan 28, 2021
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Chores 📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2243 yard doc sudeeptarlekar/faker
2243 yard doc sudeeptarlekar/faker
2 participants
@connorshea @sudeeptarlekar