From a955289c2542e138ad274c2d428c41d0e4d9b8e5 Mon Sep 17 00:00:00 2001 From: Roberto Scolaro Date: Wed, 8 Jan 2025 09:51:46 +0000 Subject: [PATCH] refactor(libsinsp): make base transform class pure virtual Signed-off-by: Roberto Scolaro --- .../sinsp_filter_transformers/sinsp_filter_transformer.cpp | 5 ----- .../sinsp_filter_transformers/sinsp_filter_transformer.h | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.cpp b/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.cpp index 3169b3488f..1d645f1dfd 100644 --- a/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.cpp +++ b/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.cpp @@ -16,11 +16,6 @@ limitations under the License. sinsp_filter_transformer::~sinsp_filter_transformer() {} -bool sinsp_filter_transformer::transform_type(ppm_param_type& t, uint32_t& flags) const { - throw_unsupported_err(m_type); - return false; -} - bool sinsp_filter_transformer::string_transformer(std::vector& vec, ppm_param_type t, str_transformer_func_t f) { diff --git a/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.h b/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.h index 5b7f4abee8..412e7571a6 100644 --- a/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.h +++ b/userspace/libsinsp/sinsp_filter_transformers/sinsp_filter_transformer.h @@ -72,7 +72,7 @@ class sinsp_filter_transformer { virtual ~sinsp_filter_transformer(); - virtual bool transform_type(ppm_param_type& t, uint32_t& flags) const; + virtual bool transform_type(ppm_param_type& t, uint32_t& flags) const = 0; virtual bool transform_values(std::vector& vals, ppm_param_type& t,