Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support UndefinedBehaviorSanitizer in CI/test builds #1470

Closed
Tracked by #1468
LucaGuerra opened this issue Nov 3, 2023 · 1 comment · Fixed by #1685
Closed
Tracked by #1468

Support UndefinedBehaviorSanitizer in CI/test builds #1470

LucaGuerra opened this issue Nov 3, 2023 · 1 comment · Fixed by #1685
Labels
kind/feature New feature or request
Milestone

Comments

@LucaGuerra
Copy link
Contributor

LucaGuerra commented Nov 3, 2023

We have already enabled AddressSanitizer in CI with both unit and e2e tests, successfully as it allowed us to prevent a number of oob reads/writes before they landed. As we increase our testing coverage and clean up the codebase we wish to enable more safeguards and UBSan is the first that came to mind to spot potential segfaults early.

In order to do so, we need to remove some "clever code tricks" that would trip UBSan, mostly regarding misaligned memory accesses. This gives us another opportunity to clean up the codebase. We have already started in #1447 bringing the warnings from 154 to 29 but we need to continue until at least unit tests and e2e give 0 warnings, at which point we can enable UBSan.

@LucaGuerra
Copy link
Contributor Author

/milestone 0.15.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants