Better handle null when updating device names

[TheOneWithTheBraid]

Checklist

• I could not find a solution in the documentation, the existing issues or discussions.
• I already asked for help in the chat

In which Project did the bug appear?

Other

If you selected "Other" as Project, please enter in which project the bug occurred.

matrix-dart-sdk

On which platform did the bug appear?

Android

SDK Version

v0.38.0

Describe the problem caused by this bug

The Client.updateDevice() method accepts a nullable String as displayName. Sadly, when the displayName is null, the dispatched request will omit the parameter. So, in fact, it is impossible to use the SDK to remove the display name of a device.

https://spec.matrix.org/latest/client-server-api/#put_matrixclientv3devicesdeviceid

Steps To Reproduce

No response

Screenshots or Logs

No response

Security related

No response

[krille-chan]

Would it work to just send an empty string instead? Element Web seems to does the same when trying to delete the displayname

[TheOneWithTheBraid]

Nope, sadly an empty display name causes the device to appear with an empty String. My suggestion is to simply send the null value since there is no other parameter anyway. If a client calls the function, they can validate the data themselves.