Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

delegates doesn't pull the __init__ of a class #217

Closed
muellerzr opened this issue Nov 20, 2020 · 0 comments
Closed

delegates doesn't pull the __init__ of a class #217

muellerzr opened this issue Nov 20, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@muellerzr
Copy link
Contributor

muellerzr commented Nov 20, 2020

There is currently a bug with tab completion when it comes to classes and delegates. A prime example is Datasets. It's setup as:

@delegates(TfmdLists)
class Datasets(FilteredBase)

When performing a tab-hint to see the possible parameters, we should see both its parameters as well as TfmdLists for the kwargs. Instead we currently see:
image

Another example is here is the results of doc:
image

You can see the kwargs were present in the first, dropped in the last but only a part of TfmdLists' parameters were added. For extra clarity I will manually adjust the delegates() to include TfmdLists' __init__, where we can see it working as expected:

image

@jph00 jph00 added the bug Something isn't working label Dec 21, 2020
@jph00 jph00 closed this as completed in 73b8e13 Dec 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants