make patch more compatible with classmethods #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Said issue on the forums: https://forums.fast.ai/t/pilbase-create-failed-to-work-after-patched-and-transformed/87853 cc @hamelsmu |
|
Please clean the notebooks |
|
Super sorry, I have cleaned the nbs. I hope that sorts out the CI tests |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr helps fix an issue that was reported on the forums.
patchwhen used with classmethods propagates the type_hints of theclsarg into thepatch_tofunction. This causesTransform'sTypeDispatchto receive the wrong type_hints