Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dropped uglifier support #166

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Dropped uglifier support #166

merged 1 commit into from
Jul 31, 2019

Conversation

L2jLiga
Copy link
Member

@L2jLiga L2jLiga commented May 8, 2019

As far as I understand the issue #97, uglify-es was added to improve throughput in Node.js 6 which is EOL nowadays and I guess it can be safety dropped now.
One more point to drop support is that uglify-es is no longer maintained

Closes #97

@mcollina
Copy link
Member

Good work! We'll land this when we cut a new major dropping Node 6 support.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

I think we should land this, drop Node 6, and cut a new major.

@L2jLiga
Copy link
Member Author

L2jLiga commented Jul 29, 2019

I can rebase it on top of master

upd: done

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina we can't drop Node v6 for now, otherwise we will not able to use it Fastify.

@mcollina mcollina changed the base branch from master to next July 31, 2019 07:10
@mcollina
Copy link
Member

I've rebased this to a next branch, so we can land when we cut v2.

@mcollina mcollina merged commit bd0679e into fastify:next Jul 31, 2019
@L2jLiga L2jLiga deleted the remove-uglifier-support branch July 31, 2019 07:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants