Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

request: high res images #825

Open
1 task done
EvolutionX-10 opened this issue Apr 27, 2023 · 2 comments
Open
1 task done

request: high res images #825

EvolutionX-10 opened this issue Apr 27, 2023 · 2 comments

Comments

@EvolutionX-10
Copy link

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

High resolution images of pokemon would be a neat addition

Desired solution

redirection links to serebii images

Alternatives considered

none

Additional context

No response

@favna
Copy link
Member

favna commented Apr 30, 2023

Work started in the feat/highres-sprites branch but I'm not sure how to tackle the high-res sprites. Serebii is just too darn inconsistent in their URLs
For example the three forms of Tauros Paldean:
https://www.serebii.net/scarletviolet/pokemon/new/128-p.png
https://www.serebii.net/scarletviolet/pokemon/new/128-b.png
https://www.serebii.net/scarletviolet/pokemon/new/128-a.png

Sure the top one could be parsed from paldea as form. Still, the other two are actually called Paldean-Fire and Paldean-Water except Serebii insists on using battle and aqua, their alternative non-parseable form names. Smogon uses the fire and water additions because it makes sense and is easily parseable and distinguishable especially because the -a postfix is also used for Alolan forms.

And on top of that, I also cannot find a solid list of Pokemon that are not transferrable from Gen 7 to Gen 8 through Pokemon Home. This becomes a problem with something like Alolan Rattata which is only available in Gen 7, whereas Alolan Marowak is available in Gen 8. So I cannot simply look at the form and say "oh yes pick that URL" either.

So I'm honestly stuck. I don't know how I can reliably get the proper URLs clearly not through Serebii.

@favna
Copy link
Member

favna commented Aug 29, 2023

We can leverage https://github.com/HybridShivam/Pokemon/ for this, however, it does not yet have generation 9 assets. Those will be added later. Tracking that in HybridShivam/Pokemon#11

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants