Quoted attributes regex fix (#17)

* Fixed newline characters inside of quoted attributes * Added test * Swapped to negation selector
fb55 · Jan 20, 2018 · 2e83211 · 2e83211
1 parent fd6b9f6
commit 2e83211
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -5,7 +5,7 @@ module.exports = parse;
 var re_name = /^(?:\\.|[\w\-\u00c0-\uFFFF])+/,
     re_escape = /\\([\da-f]{1,6}\s?|(\s)|.)/ig,
     //modified version of https://github.com/jquery/sizzle/blob/master/src/sizzle.js#L87
-    re_attr = /^\s*((?:\\.|[\w\u00c0-\uFFFF\-])+)\s*(?:(\S?)=\s*(?:(['"])(.*?)\3|(#?(?:\\.|[\w\u00c0-\uFFFF\-])*)|)|)\s*(i)?\]/;
+    re_attr = /^\s*((?:\\.|[\w\u00c0-\uFFFF\-])+)\s*(?:(\S?)=\s*(?:(['"])([^]*?)\3|(#?(?:\\.|[\w\u00c0-\uFFFF\-])*)|)|)\s*(i)?\]/;
 
 var actionTypes = {
 	__proto__: null,

diff --git a/tests/test.js b/tests/test.js
@@ -250,6 +250,21 @@ var tests = [
 		],
 		"quoted attribute with spaces"
 	],
+	[
+		"[value=\"\nsome text\n\"]",
+		[
+			[
+				{
+					"type": "attribute",
+					"name": "value",
+					"action": "equals",
+					"value": "\nsome text\n",
+					"ignoreCase": false
+				}
+			]
+		],
+		"quoted attribute with internal newline"
+	],
 	[
 		"[name=foo\\.baz]",
 		[