You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the getListOf[x] methods have names which are consistent with the name of the associated SED attribute. One exception is RepeatedTask.getListOfTaskChanges (rather than RepeatedTask.getListOfChanges). For consistency, it would be helpful to rename this method. Since that would break code that depends on the old name, an alias could be added so that either getListOfTaskChanges or getListOfChanges could be used, with both functions returning the same value.
The text was updated successfully, but these errors were encountered:
The same is true for the 'line' and 'marker' children of Style: libsedml refers to them in the functions as 'LineStyle' and 'MarkerStyle' instead of just 'line' and 'marker' which are the actual names of the elements.
@luciansmith that is because every sed-ml class allready has a getLine function, that would return the line number. Thus i could not create another getLine function for returning the line style. So we had issue #67 , cause initially only line was different, then to make those consistent also the marker and fill were renamed within the library.
as to the original issue from @jonrkarr it is called listOfTaskChanges, as we already have a listOfChanges for the model changes ... so what is returned here is a list of constructs ... but getListOfSetValues sounded really odd to me. So unless you insist (and let me know what the name should be), I would rather leave it as is.
All of the
getListOf[x]
methods have names which are consistent with the name of the associated SED attribute. One exception isRepeatedTask.getListOfTaskChanges
(rather thanRepeatedTask.getListOfChanges
). For consistency, it would be helpful to rename this method. Since that would break code that depends on the old name, an alias could be added so that eithergetListOfTaskChanges
orgetListOfChanges
could be used, with both functions returning the same value.The text was updated successfully, but these errors were encountered: