Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Notification tests assume ability to create empty Direct/Indirect containers #258

Open
acoburn opened this issue Oct 15, 2018 · 1 comment

Comments

@acoburn
Copy link

acoburn commented Oct 15, 2018

The Notification tests try to create various container types and then look to see if these container types appear in the notifications.

The problem with this test is that the code tries to create Direct and Indirect containers without any of the required ldp properties. According to the LDP spec, direct and indirect containers must have ldp:membershipResource and one of either ldp:hasMemberRelation or ldp:isMemberOfRelation. Any LDP server that enforces these restrictions will fail at that point, regardless of what rdf:type values the notifications happen to have.

@acoburn
Copy link
Author

acoburn commented Oct 15, 2018

Furthermore, the test assumes that the LDP server supports direct and indirect containers, which (IIRC) is not a requirement.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant