Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Overly specific tests for link headers #261

Open
acoburn opened this issue Oct 16, 2018 · 0 comments
Open

Overly specific tests for link headers #261

acoburn opened this issue Oct 16, 2018 · 0 comments

Comments

@acoburn
Copy link

acoburn commented Oct 16, 2018

This method is used to compare link headers for equivalence. This is used, for example, when checking whether a certain Memento link header is present. The issue here is that the comparison is exact; if the incoming link header contains, for example, a title attribute or any other valid Link property, the test will fail. It seems that the code should only be checking the IRI and rel parameter for a match -- that will confirm the presence of such a link header.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant