Skip to content

Commit

Permalink
Fix unit test warnings related to file_url (#1726)
Browse files Browse the repository at this point in the history
Signed-off-by: ted chang <htchang@us.ibm.com>
  • Loading branch information
tedhtchang authored Jul 22, 2021
1 parent a68dc85 commit 5c7c240
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def prep_local_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]:
df.to_parquet(f.name)
file_source = FileSource(
file_format=ParquetFormat(),
file_url=f"file://{f.name}",
path=f"file://{f.name}",
event_timestamp_column="ts",
created_timestamp_column="created_ts",
date_partition_column="",
Expand Down Expand Up @@ -242,7 +242,7 @@ def prep_redis_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]:
df.to_parquet(f.name)
file_source = FileSource(
file_format=ParquetFormat(),
file_url=f"file://{f.name}",
path=f"file://{f.name}",
event_timestamp_column="ts",
created_timestamp_column="created_ts",
date_partition_column="",
Expand Down Expand Up @@ -284,7 +284,7 @@ def prep_dynamodb_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]:
df.to_parquet(f.name)
file_source = FileSource(
file_format=ParquetFormat(),
file_url=f"file://{f.name}",
path=f"file://{f.name}",
event_timestamp_column="ts",
created_timestamp_column="created_ts",
date_partition_column="",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def test_apply_feature_view_success(test_feature_store):
# Create Feature Views
batch_source = FileSource(
file_format=ParquetFormat(),
file_url="file://feast/*",
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
Expand Down Expand Up @@ -287,7 +287,7 @@ def test_apply_feature_view_integration(test_feature_store):
# Create Feature Views
batch_source = FileSource(
file_format=ParquetFormat(),
file_url="file://feast/*",
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
Expand Down Expand Up @@ -356,7 +356,7 @@ def test_apply_object_and_read(test_feature_store):
# Create Feature Views
batch_source = FileSource(
file_format=ParquetFormat(),
file_url="file://feast/*",
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/tests/integration/registration/test_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def test_apply_feature_view_success(test_registry):
# Create Feature Views
batch_source = FileSource(
file_format=ParquetFormat(),
file_url="file://feast/*",
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
Expand Down Expand Up @@ -230,7 +230,7 @@ def test_apply_feature_view_integration(test_registry):
# Create Feature Views
batch_source = FileSource(
file_format=ParquetFormat(),
file_url="file://feast/*",
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/utils/data_source_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def prep_file_source(df, event_timestamp_column=None) -> FileSource:
df.to_parquet(f.name)
file_source = FileSource(
file_format=ParquetFormat(),
file_url=f.name,
path=f.name,
event_timestamp_column=event_timestamp_column,
)
yield file_source
Expand Down

0 comments on commit 5c7c240

Please # to comment.