-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove sys.exit from exception handling #1666
Comments
Is the "simple" fix just to reraise everything? Or is it more nuanced than that? |
@charliec443 I think it's sufficient to not catch the exception at all if all we're doing it re-raising it - but I was looking at the code and I don't see a |
Yes I think you're right. it was progressively removed in in some of the PRs, I think namely the Redshift one. |
Alright, going to close this out in that case! |
Fixed by #1641 |
We're currently calling sys.exit on exception handling here https://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_store.py#L301, which will cause the Feast (and wrapping) process to exit. Instead, we should either reraise or even just let the exception bubble up.
The text was updated successfully, but these errors were encountered: