Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add more validation in feature spec registration #11

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Add more validation in feature spec registration #11

merged 1 commit into from
Dec 24, 2018

Conversation

pradithya
Copy link
Collaborator

Add validation in feature spec registration to prevent users from registering feature that uses unsupported storage.

@pradithya pradithya requested review from zhilingc and woop December 20, 2018 11:26
woop
woop approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhilingc zhilingc mentioned this pull request Dec 21, 2018
Closed
zhilingc
zhilingc approved these changes Dec 24, 2018
View reviewed changes
Copy link
Collaborator

@zhilingc zhilingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@zhilingc zhilingc merged commit 3b17d7a into master Dec 24, 2018
@zhilingc zhilingc deleted the feature_spec_validation branch December 24, 2018 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@woop woop woop approved these changes

@zhilingc zhilingc zhilingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradithya @woop @zhilingc