-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Option for additional spark configuration #1198
Conversation
Signed-off-by: mike0sv <mike0sv@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mike0sv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mike0sv. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: mike0sv <mike0sv@gmail.com>
Signed-off-by: mike0sv <mike0sv@gmail.com>
/kind feature |
Signed-off-by: mike0sv <mike0sv@gmail.com>
Signed-off-by: mike0sv <mike0sv@gmail.com>
/retest |
Hey guys! I've been pretty preoccupied lately and didnt have the time to work on this. But I'll return to this as soon as I have the time |
@mike0sv: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mike0sv apologies about the slow feedback on this PR. We need to move it to https://github.com/feast-dev/feast-spark though, since that will be the new home for Spark related code. |
Signed-off-by: mike0sv mike0sv@gmail.com
What this PR does / why we need it:
Adds an option for additional spark configuration
Which issue(s) this PR fixes:
Fixes #1168
Does this PR introduce a user-facing change?: