Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option for additional spark configuration #1198

Closed
wants to merge 6 commits into from

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Nov 26, 2020

Signed-off-by: mike0sv mike0sv@gmail.com

What this PR does / why we need it:
Adds an option for additional spark configuration
Which issue(s) this PR fixes:

Fixes #1168

Does this PR introduce a user-facing change?:

Added SPARK_ADDITIONAL_OPTS config option to enable users to provide additional config for Spark jobs

Signed-off-by: mike0sv <mike0sv@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mike0sv
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @mike0sv. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: mike0sv <mike0sv@gmail.com>
Signed-off-by: mike0sv <mike0sv@gmail.com>
Signed-off-by: mike0sv <mike0sv@gmail.com>
@woop
Copy link
Member

woop commented Nov 26, 2020

/kind feature
/ok-to-test

Signed-off-by: mike0sv <mike0sv@gmail.com>
Signed-off-by: mike0sv <mike0sv@gmail.com>
@mike0sv
Copy link
Contributor Author

mike0sv commented Nov 30, 2020

/retest

@mike0sv
Copy link
Contributor Author

mike0sv commented Dec 17, 2020

Hey guys! I've been pretty preoccupied lately and didnt have the time to work on this. But I'll return to this as soon as I have the time

@feast-ci-bot
Copy link
Collaborator

@mike0sv: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-gcp 61a6079 link /test test-end-to-end-gcp
test-end-to-end-sparkop 61a6079 link /test test-end-to-end-sparkop
test-end-to-end-azure 61a6079 link /test test-end-to-end-azure
test-telemetry 61a6079 link /test test-telemetry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop
Copy link
Member

woop commented Feb 8, 2021

@mike0sv apologies about the slow feedback on this PR. We need to move it to https://github.com/feast-dev/feast-spark though, since that will be the new home for Spark related code.

@woop woop closed this Feb 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional configuration options for Spark jobs
3 participants