Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix noisy path warning #1452

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

woop
Copy link
Member

@woop woop commented Apr 9, 2021

Signed-off-by: Willem Pienaar git@willem.co

What this PR does / why we need it:

Stops a noisy warning when the user provides a path argument to a FileSource (which is correct), but the warning mistakes this for file_url.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Willem Pienaar <git@willem.co>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
Copy link
Collaborator

jklegar commented Apr 9, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 41a7a4a into feast-dev:master Apr 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants