Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes python 3.6 issue #1503

Closed
wants to merge 2 commits into from
Closed

Fixes python 3.6 issue #1503

wants to merge 2 commits into from

Conversation

HeardACat
Copy link
Contributor

@HeardACat HeardACat commented Apr 25, 2021

What this PR does / why we need it:

This PR address errors which working in Python 3.6 local mode
I have tested briefly on Python 3.8 (Ubuntu 20.04)

Which issue(s) this PR fixes:

Fixes #1502
I have tested against Python 3.8 on Ubuntu as well.

Does this PR introduce a user-facing change?:

NONE 

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chappers
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @chappers. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Apr 26, 2021

/ok-to-test

@woop
Copy link
Member

woop commented Apr 26, 2021

/kind bug

@tsotnet
Copy link
Collaborator

tsotnet commented Apr 26, 2021

@chappers Thank you for submitting a PR. The issue here is that we do not support Python 3.6. You need to be on Python 3.7+ to use Feast. Unfortunately our setup.py does not reflect that, but we'll update it.

@Joostrothweiler
Copy link
Contributor

Joostrothweiler commented Jun 1, 2021

@tsotnet could you maybe elaborate on the reasons for not supporting Python 3.6?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.6 Local Mode breaks due to usage of pathlib.Path and sqlite3
5 participants