Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure that only None types fail predicate #1580

Merged
merged 2 commits into from
May 27, 2021
Merged

Ensure that only None types fail predicate #1580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216b652
Ensure that only None types fail predicate
woop May 24, 2021
e010ddd
Fix lint
woop May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sdk/python/feast/type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,11 @@ def _python_value_to_proto_value(feast_value_type, value) -> ProtoValue:
def python_value_to_proto_value(
value: Any, feature_type: ValueType = None
) -> ProtoValue:
value_type = python_type_to_feast_value_type("", value) if value else feature_type
value_type = (
python_type_to_feast_value_type("", value)
if value is not None
else feature_type
)
return _python_value_to_proto_value(value_type, value)


Expand Down