-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow specifying FeatureServices in FeatureStore methods #1691
Allow specifying FeatureServices in FeatureStore methods #1691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
- Coverage 78.77% 78.69% -0.08%
==========================================
Files 77 80 +3
Lines 6529 6765 +236
==========================================
+ Hits 5143 5324 +181
- Misses 1386 1441 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Good catch, added |
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
/lgtm |
Signed-off-by: Achal Shah <achals@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
FeatureServices only contain references to Features in FeatureViews. This PR allows them to be consumed in the
get_historical_features
andonline_read
methods.Which issue(s) this PR fixes:
Part 2 for #1572
Does this PR introduce a user-facing change?: