Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow specifying FeatureServices in FeatureStore methods #1691

Merged
merged 58 commits into from
Jul 22, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jul 6, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

FeatureServices only contain references to Features in FeatureViews. This PR allows them to be consumed in the get_historical_features and online_read methods.

Which issue(s) this PR fixes:

Part 2 for #1572

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1691 (03d0ba5) into master (5c7c240) will decrease coverage by 0.07%.
The diff coverage is 69.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   78.77%   78.69%   -0.08%     
==========================================
  Files          77       80       +3     
  Lines        6529     6765     +236     
==========================================
+ Hits         5143     5324     +181     
- Misses       1386     1441      +55     
Flag Coverage Δ
integrationtests 78.62% <69.76%> (-0.07%) ⬇️
unittests 62.20% <50.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...alization/test_offline_online_store_consistency.py 100.00% <ø> (ø)
...n/tests/integration/online_store/test_e2e_local.py 100.00% <ø> (ø)
.../integration/online_store/test_online_retrieval.py 100.00% <ø> (ø)
sdk/python/feast/repo_operations.py 31.33% <16.66%> (-1.17%) ⬇️
sdk/python/feast/cli.py 43.67% <30.00%> (-2.85%) ⬇️
sdk/python/feast/errors.py 70.78% <40.00%> (-1.84%) ⬇️
sdk/python/feast/feature_service.py 71.21% <47.82%> (ø)
sdk/python/feast/registry.py 79.34% <74.19%> (-0.53%) ⬇️
sdk/python/feast/feature.py 75.00% <75.00%> (+3.33%) ⬆️
sdk/python/feast/feature_store.py 93.50% <88.63%> (-1.22%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7c240...03d0ba5. Read the comment docs.

@achals achals added the kind/feature New feature or request label Jul 6, 2021
@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Jul 6, 2021
achals added 8 commits July 7, 2021 13:14
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Copy link
Member Author

achals commented Jul 19, 2021

Are we testing feature services for historical retrieval anywhere?

Good catch, added

achals added 4 commits July 19, 2021 14:21
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
achals added 3 commits July 19, 2021 17:08
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from woop July 22, 2021 19:15
achals added 4 commits July 22, 2021 12:16
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@woop
Copy link
Member

woop commented Jul 22, 2021

/lgtm

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 22, 2021
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jul 22, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7dff49a into feast-dev:master Jul 22, 2021
@achals achals deleted the achal/feature-service-api branch July 22, 2021 20:06
@achals achals linked an issue Aug 3, 2021 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Feature Services
5 participants