Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a description field the Feature Service class and proto #1771

Merged

Conversation

achals
Copy link
Member

@achals achals commented Aug 9, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1770

Does this PR introduce a user-facing change?:

Added a description field to the Feature Service class and proto

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #1771 (c985ae5) into master (316aabb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
+ Coverage   84.73%   84.76%   +0.02%     
==========================================
  Files          85       86       +1     
  Lines        6297     6308      +11     
==========================================
+ Hits         5336     5347      +11     
  Misses        961      961              
Flag Coverage Δ
integrationtests 84.68% <100.00%> (+0.02%) ⬆️
unittests 64.31% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_service.py 72.85% <100.00%> (+1.64%) ⬆️
sdk/python/tests/unit/test_feature_service.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316aabb...c985ae5. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals added the kind/bug label Aug 9, 2021
@feast-ci-bot feast-ci-bot merged commit 8ef2053 into feast-dev:master Aug 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureService should support "description" as first class named-value argument as Entity does
4 participants