Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upload benchmark information to S3 after integration test runs #1878

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Upload benchmark information to S3 after integration test runs #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
430672c
Upload benchmark information to S3 after integration test runs
achals Sep 17, 2021
373b0ac
Fix action
achals Sep 17, 2021
f57a058
newline
achals Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ jobs:
fail_ci_if_error: true
verbose: true
- name: Benchmark python
run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-json=./benchmarks.json
- name: Upload Benchmark Artifact
uses: actions/upload-artifact@v2
with:
name: benchmarks.json
path: benchmarks.json
run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data
- name: Upload Benchmark Artifact to S3
run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmarks
9 changes: 3 additions & 6 deletions .github/workflows/pr_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ jobs:
fail_ci_if_error: true
verbose: true
- name: Benchmark python
run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-json=./benchmarks.json
- name: Upload Benchmark Artifact
uses: actions/upload-artifact@v2
with:
name: benchmarks.json
path: benchmarks.json
run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data
- name: Upload Benchmark Artifact to S3
run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmarks
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,4 +187,7 @@ dmypy.json
# Protos
sdk/python/docs/html
sdk/python/feast/protos/
sdk/go/protos/
sdk/go/protos/

#benchmarks
.benchmarks
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ install-python:
python -m pip install -e sdk/python -U --use-deprecated=legacy-resolver

benchmark-python:
FEAST_USAGE=False IS_TEST=True pytest --integration --benchmark sdk/python/tests
FEAST_USAGE=False IS_TEST=True pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests

test-python:
FEAST_USAGE=False IS_TEST=True pytest -n 8 sdk/python/tests
Expand Down