-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
KafkaIO implementation for feast #19
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
ingestion/src/main/java/feast/ingestion/deserializer/FeatureRowDeserializer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package feast.ingestion.deserializer; | ||
|
|
||
| import com.google.protobuf.InvalidProtocolBufferException; | ||
| import feast.types.FeatureRowProto.FeatureRow; | ||
| import org.apache.kafka.common.errors.SerializationException; | ||
| import org.apache.kafka.common.serialization.Deserializer; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Deserializer for Kafka to deserialize Protocol Buffers messages | ||
| * | ||
| * @param <FeatureRow> Protobuf message type | ||
| */ | ||
| public class FeatureRowDeserializer implements Deserializer<FeatureRow> { | ||
|
|
||
| @Override | ||
| public void configure(Map configs, boolean isKey) { | ||
| } | ||
|
|
||
| @Override | ||
| public FeatureRow deserialize(String topic, byte[] data) { | ||
| try { | ||
| return FeatureRow.parseFrom(data); | ||
| } catch (InvalidProtocolBufferException e) { | ||
| throw new SerializationException("Error deserializing FeatureRow from Protobuf message", e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
ingestion/src/main/java/feast/ingestion/deserializer/FeatureRowKeyDeserializer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package feast.ingestion.deserializer; | ||
|
|
||
| import com.google.protobuf.InvalidProtocolBufferException; | ||
| import feast.types.FeatureRowProto.*; | ||
| import org.apache.kafka.common.errors.SerializationException; | ||
| import org.apache.kafka.common.serialization.Deserializer; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Deserializer for Kafka to deserialize Protocol Buffers messages | ||
| * | ||
| * @param <FeatureRowKey> Protobuf message type | ||
| */ | ||
| public class FeatureRowKeyDeserializer implements Deserializer<FeatureRowKey> { | ||
|
|
||
| @Override | ||
| public void configure(Map configs, boolean isKey) { | ||
| } | ||
|
|
||
| @Override | ||
| public FeatureRowKey deserialize(String topic, byte[] data) { | ||
| try { | ||
| return FeatureRowKey.parseFrom(data); | ||
| } catch (InvalidProtocolBufferException e) { | ||
| throw new SerializationException("Error deserializing FeatureRowKey from Protobuf message", e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
ingestion/src/main/java/feast/ingestion/transform/FeatureEnums.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package feast.ingestion.transform; | ||
|
|
||
| public class FeatureEnums { | ||
| public enum InputSource { | ||
| FILE, | ||
| BIGQUERY, | ||
| PUBSUB, | ||
| KAFKA | ||
| } | ||
|
|
||
| public enum FileFormat { | ||
| CSV, | ||
| JSON | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't print out the credentials, right?