Remove refs to tensorflow_metadata #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Shah <achals@gmail.com>
achals
requested review from
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2063 +/- ##
==========================================
- Coverage 83.61% 83.32% -0.29%
==========================================
Files 100 100
Lines 8080 8080
==========================================
- Hits 6756 6733 -23
- Misses 1324 1347 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind housekeeping |
chhabrakadabra
added a commit
to chhabrakadabra/feast
that referenced
this pull request
Sep 30, 2022
Turns out that this dependency is not required. We removed all references to it in [this PR](feast-dev#2063), but did not remove it from `setup.py`. Removing it has caused many of the restrictions imposed in previous commits to be unnecessary. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com>
feast-ci-bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Initial implementation of BigTable online store. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Attempt to run bigtable integration tests. Currently focusing on just getting the tests running locally. I've only build python3.8 requirements. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Got the BigTable tests running in local containers Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Set serialization version when computing entity ID Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Switch to the recommended layout in bigtable. This was recommended by the BigTable dev team. Details of this layout will be added to the documentation in a future commit. Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Minor bugfixes. - If a row is empty when fetching data, don't process it more. - If a task in the threadpool fails, bubble up that failure. - If a `created_ts` is not available, use an empty string. `None` does not automatically serialize to bytes. Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Move BigTable online store out of contrib As per feedback on the PR. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Attempt to run integration tests in CI. Provide the GCP project and the bigtable instance ID for the tests to connect to. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Delete tables for entity-less feature views. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Table names should be smaller than 50 characters This is BigTable's table length limit and it's causing test failures. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Optimize bigtable reads. - Fetch all the rows in one bigtable fetch. - Get only the columns that are necessary (using a column regex filter). Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * dynamodb: switch to `mock_dynamodb` The latest rebuilding of requirements has upgraded the `moto` library past the `4.0.0` release, which has a couple of breaking changes. Specifically, the `mock_dynamodb2` decorator has been deprecated. See https://github.com/spulec/moto/blob/master/CHANGELOG.md#400 for more details. The actual PR (getmoto/moto#4919) mentions that it's because the `mock_dynamodb` decorator is now equivalent to the `mock_dynamodb2` decorator. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * minor: rename `BigTable` to `Bigtable` This matches the GCP docs. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Wrote some Bigtable documentation. Closely mirrors the docs for the other online stores. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Bugfix: Deal with missing row keys. It looks like the bigtable client will just skip over non-existent row keys. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Fix linting issues. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Generate requirements files. - As of version `1.49`, the various python packages in the [grpc repo](https://github.com/grpc/grpc/tree/master/src/python) require `protobuf>=4.21.3`. Unfortunately, this is incompatible with all versions of `tensorflow-metadata` (see [this issue](tensorflow/metadata#37)). And since `piptools` doesn't backtrack during dependency resolution, the requirement files cannot be regenerated without adding an upper limit on these grpc libraries directly in `setup.py`. - The previous attempt to upgrade usages of the `mock_dynamodb2` decorator to the newest version failed. Since I'm not an expert in dynamodb, it made sense to just cap the test tool to the version already being used in CI. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Don't bother materializing created timestamp. Had a discussion with Danny about whether it's useful to copy this column. He agreed that there's no value to storing this in the online store. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Remove `tensorflow-metadata`. Turns out that this dependency is not required. We removed all references to it in [this PR](#2063), but did not remove it from `setup.py`. Removing it has caused many of the restrictions imposed in previous commits to be unnecessary. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Minor fix to Bigtable documentation. Feedback from Danny mentioned that Bigtable should be able to store multiple versions of the same key and fetch the latest at read time. This makes sense and means that concurrent writes should work just fine. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * update roadmap docs Signed-off-by: Danny Chiao <danny@tecton.ai> * Fix roadmap doc Signed-off-by: Danny Chiao <danny@tecton.ai> * Change link to point to roadmap page Signed-off-by: Danny Chiao <danny@tecton.ai> * change order in roadmap Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> Signed-off-by: Danny Chiao <danny@tecton.ai> Co-authored-by: Danny Chiao <danny@tecton.ai>
franciscojavierarceo
pushed a commit
to franciscojavierarceo/feast
that referenced
this pull request
Oct 18, 2022
* Initial implementation of BigTable online store. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Attempt to run bigtable integration tests. Currently focusing on just getting the tests running locally. I've only build python3.8 requirements. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Got the BigTable tests running in local containers Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Set serialization version when computing entity ID Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Switch to the recommended layout in bigtable. This was recommended by the BigTable dev team. Details of this layout will be added to the documentation in a future commit. Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Minor bugfixes. - If a row is empty when fetching data, don't process it more. - If a task in the threadpool fails, bubble up that failure. - If a `created_ts` is not available, use an empty string. `None` does not automatically serialize to bytes. Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> * Move BigTable online store out of contrib As per feedback on the PR. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Attempt to run integration tests in CI. Provide the GCP project and the bigtable instance ID for the tests to connect to. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Delete tables for entity-less feature views. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Table names should be smaller than 50 characters This is BigTable's table length limit and it's causing test failures. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Optimize bigtable reads. - Fetch all the rows in one bigtable fetch. - Get only the columns that are necessary (using a column regex filter). Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * dynamodb: switch to `mock_dynamodb` The latest rebuilding of requirements has upgraded the `moto` library past the `4.0.0` release, which has a couple of breaking changes. Specifically, the `mock_dynamodb2` decorator has been deprecated. See https://github.com/spulec/moto/blob/master/CHANGELOG.md#400 for more details. The actual PR (getmoto/moto#4919) mentions that it's because the `mock_dynamodb` decorator is now equivalent to the `mock_dynamodb2` decorator. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * minor: rename `BigTable` to `Bigtable` This matches the GCP docs. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Wrote some Bigtable documentation. Closely mirrors the docs for the other online stores. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Bugfix: Deal with missing row keys. It looks like the bigtable client will just skip over non-existent row keys. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Fix linting issues. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Generate requirements files. - As of version `1.49`, the various python packages in the [grpc repo](https://github.com/grpc/grpc/tree/master/src/python) require `protobuf>=4.21.3`. Unfortunately, this is incompatible with all versions of `tensorflow-metadata` (see [this issue](tensorflow/metadata#37)). And since `piptools` doesn't backtrack during dependency resolution, the requirement files cannot be regenerated without adding an upper limit on these grpc libraries directly in `setup.py`. - The previous attempt to upgrade usages of the `mock_dynamodb2` decorator to the newest version failed. Since I'm not an expert in dynamodb, it made sense to just cap the test tool to the version already being used in CI. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Don't bother materializing created timestamp. Had a discussion with Danny about whether it's useful to copy this column. He agreed that there's no value to storing this in the online store. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Remove `tensorflow-metadata`. Turns out that this dependency is not required. We removed all references to it in [this PR](feast-dev#2063), but did not remove it from `setup.py`. Removing it has caused many of the restrictions imposed in previous commits to be unnecessary. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * Minor fix to Bigtable documentation. Feedback from Danny mentioned that Bigtable should be able to store multiple versions of the same key and fetch the latest at read time. This makes sense and means that concurrent writes should work just fine. Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> * update roadmap docs Signed-off-by: Danny Chiao <danny@tecton.ai> * Fix roadmap doc Signed-off-by: Danny Chiao <danny@tecton.ai> * Change link to point to roadmap page Signed-off-by: Danny Chiao <danny@tecton.ai> * change order in roadmap Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com> Signed-off-by: Abhin Chhabra <chhabra.abhin@gmail.com> Signed-off-by: Danny Chiao <danny@tecton.ai> Co-authored-by: Danny Chiao <danny@tecton.ai>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Basically the same as #2058, but I had to recreate the PR since I couldn't reopen that one.
Does this PR introduce a user-facing change?: