-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add docker-compose for Feast #312
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaihendry If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kaihendry. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Would you mind renaming this to capture the contents of the PR? That makes it easier for us to build change logs later. You can look at the following for closing an issue based on a PR |
f619ac2
to
a20f3c9
Compare
Tested like so:
Updated the commit message btw |
Closes feast-dev#272 Tested by: $ grpc_cli ls localhost:6565 grpc.health.v1.Health grpc.reflection.v1alpha.ServerReflection feast.core.CoreService $ grpc_cli ls localhost:6566 grpc.health.v1.Health grpc.reflection.v1alpha.ServerReflection feast.serving.ServingService
Thought tbh I don't actually know if the redis is being used
b410a53
to
7dcc99a
Compare
@kaihendry, minimally we need to ensure that ingestion and retrieval works for this to be merged in. |
I'm not how to test that. Are there some commands you can suggest I can run to ensure I can store and retrieve a feature? I am also investigating in parallel some sort of automated testing framework. https://stackoverflow.com/questions/59024442/best-practices-for-docker-compose-testing |
@kaihendry I think we should close this PR in favour of this one: #328 |
No description provided.