Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add docker-compose for Feast #312

Closed
wants to merge 2 commits into from

Conversation

kaihendry
Copy link

No description provided.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaihendry
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhilingc

If they are not already assigned, you can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @kaihendry. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Nov 18, 2019

Would you mind renaming this to capture the contents of the PR? That makes it easier for us to build change logs later.

You can look at the following for closing an issue based on a PR
https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords

@kaihendry
Copy link
Author

kaihendry commented Nov 18, 2019

Tested like so:

[hendry@t480s ~]$ grpc_cli ls localhost:6565
grpc.health.v1.Health
grpc.reflection.v1alpha.ServerReflection
feast.core.CoreService

[hendry@t480s ~]$ grpc_cli ls localhost:6566
grpc.health.v1.Health
grpc.reflection.v1alpha.ServerReflection
feast.serving.ServingService

Updated the commit message btw

Kai Hendry added 2 commits November 19, 2019 09:48
Closes feast-dev#272

Tested by:

    $ grpc_cli ls localhost:6565
    grpc.health.v1.Health
    grpc.reflection.v1alpha.ServerReflection
    feast.core.CoreService

    $ grpc_cli ls localhost:6566
    grpc.health.v1.Health
    grpc.reflection.v1alpha.ServerReflection
    feast.serving.ServingService
Thought tbh I don't actually know if the redis is being used
@woop woop changed the title Closes https://github.com/gojek/feast/issues/272 Add docker-compose for Feast Nov 24, 2019
@woop
Copy link
Member

woop commented Nov 25, 2019

@kaihendry, minimally we need to ensure that ingestion and retrieval works for this to be merged in.

@kaihendry
Copy link
Author

kaihendry commented Nov 25, 2019

I'm not how to test that. Are there some commands you can suggest I can run to ensure I can store and retrieve a feature?

I am also investigating in parallel some sort of automated testing framework. https://stackoverflow.com/questions/59024442/best-practices-for-docker-compose-testing

@woop
Copy link
Member

woop commented Nov 28, 2019

@kaihendry I think we should close this PR in favour of this one: #328

@woop woop closed this Nov 28, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants