Rename metric name for request latency in feast serving #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it is consistent with the actual unit of timing being measured And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names
|
/retest |
1 similar comment
|
/retest |
|
/hold |
|
Test fails because several hours ago with this error 2 potential fixes:
- time_offset = datetime.utcnow().replace(tzinfo=pytz.utc)
+ time_offset = datetime.utcnow().replace(tzinfo=None) |
|
/retest |
davidheryanto
force-pushed
the
fix-prometheus-metric-name-in-feast-serving
branch
from
74be918 to
3e5be55
Compare
|
Can we merge this @davidheryanto ? |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
davidheryanto
added a commit
to davidheryanto/feast
that referenced
this pull request
Feb 26, 2020
So that it is consistent with the actual unit of timing being measured And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names (cherry picked from commit 5758d99)
zhilingc
pushed a commit
that referenced
this pull request
Feb 26, 2020
So that it is consistent with the actual unit of timing being measured And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names (cherry picked from commit 5758d99)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
So that it is consistent with the actual unit of timing being measured.
And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names
Which issue(s) this PR fixes:
NONE
Does this PR introduce a user-facing change?: