Create project if not exists on applyFeatureSet #596
Conversation
|
Hi @Joostrothweiler. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @thirteen37 |
Joostrothweiler
changed the title
Joostrothweiler
changed the title
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joostrothweiler, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Awesome, thanks @Joostrothweiler! |
|
/lgtm |
* Create project if not exists on apply * Update comments to reflect new situation * Fixed typo in comment Co-authored-by: Joost Rothweiler <=> Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
* Create project if not exists on apply * Update comments to reflect new situation * Fixed typo in comment Co-authored-by: Joost Rothweiler <=> Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
What this PR does / why we need it:
Allow create_project to rerun safely #453. Instead of having to run
create_projectbefore apply, the apply method can create the project if it does not already exist.Which issue(s) this PR fixes:
Fixes #453
Does this PR introduce a user-facing change?: