Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pin Jupyter Notebook version #597

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

imjuanleonard
Copy link
Contributor

  1. Ensure that your code follows our code conventions
  2. Run unit tests and ensure that they are passing ✅
  3. If your change introduces any API changes, make sure to update the integration tests scripts
  4. Make sure documentation is updated for your PR! ✅
  5. Make sure you have signed the CLA

What this PR does / why we need it:
This issue fixes the version of pandas library used inside the Jupyter notebook
Which issue(s) this PR fixes:
Fixes #585

Does this PR introduce a user-facing change?:

NONE

@imjuanleonard
Copy link
Contributor Author

/assign @woop

@woop
Copy link
Member

woop commented Apr 3, 2020

Please remove the notebook output changes. You only need to merge in the code or config changes.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imjuanleonard, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Apr 3, 2020

/lgtm

@woop woop changed the title Tag notebook version Pin Jupyter Notebook version Apr 3, 2020
@feast-ci-bot feast-ci-bot merged commit 1decc2a into feast-dev:master Apr 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic example fails when importing Pandas
3 participants