Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix subscription config and doctests #634

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

woop
Copy link
Member

@woop woop commented Apr 19, 2020

What this PR does / why we need it:
#525 has caused some inconsistencies with e2e tests. I believe it was merged without proper e2e tests running.

This PR attempts fix to inconsistencies.

  • Subscriptions configuration isn't loading because the configuration class isn't static.
  • JavaDocs are broken (bad links)

Does this PR introduce a user-facing change?:

None

@woop woop requested review from pradithya and zhilingc as code owners April 19, 2020 14:57
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member Author

woop commented Apr 19, 2020

/test test-end-to-end-batch

@woop
Copy link
Member Author

woop commented Apr 19, 2020

/test test-end-to-end

@woop
Copy link
Member Author

woop commented Apr 20, 2020

/retest

@woop
Copy link
Member Author

woop commented Apr 20, 2020

/test test-end-to-end-batch

@woop
Copy link
Member Author

woop commented Apr 20, 2020

/test test-end-to-end

@feast-ci-bot
Copy link
Collaborator

@woop: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end d1fce36 link /test test-end-to-end
test-end-to-end-batch d1fce36 link /test test-end-to-end-batch

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop woop marked this pull request as draft April 20, 2020 02:00
@woop woop changed the title Fix bug in configuration loading for subscriptions Fix end-to-end tests on master branch Apr 20, 2020
@woop woop changed the title Fix end-to-end tests on master branch Fix subscription config and doctests Apr 20, 2020
@woop woop marked this pull request as ready for review April 20, 2020 07:36
@woop woop merged commit 0816cd4 into feast-dev:master Apr 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants