Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v0.3: Move e2e test scripts from .prow to infra #657

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

khorshuheng
Copy link
Collaborator

@khorshuheng khorshuheng commented Apr 27, 2020

What this PR does / why we need it:
In master branch, prow has been configured such that the scripts are run from the infra directory rather than .prow. This change was back-ported to v0.4 branch, but not for v0.3 branch, which will cause the prow tests to fail.

.prow config has been updated in v0.3 branch for clarity purpose.

@ches
Copy link
Member

ches commented Apr 27, 2020

/lgtm

Thanks for quickly doing the backport!

@ches
Copy link
Member

ches commented Apr 27, 2020

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ches, khorshuheng
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ches ches merged commit 1a35764 into feast-dev:v0.3-branch Apr 27, 2020
@ches ches changed the title Move e2e test scripts from .prow to infra v0.3: Move e2e test scripts from .prow to infra Apr 27, 2020
@ches ches mentioned this pull request May 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants