Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Helm chart requirements lock and version linting #925

Merged

Conversation

woop
Copy link
Member

@woop woop commented Aug 3, 2020

What this PR does / why we need it:

Allows for linting of versions based on latest stable tag, bump the requirements lock for our helm charts, and allows for specifying the amount of versions to find in a file.

Which issue(s) this PR fixes:

Fixes #924

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop force-pushed the force-and-validate-consistency-between-images branch from d922525 to 388c230 Compare August 3, 2020 15:11
@woop woop merged commit 3590339 into feast-dev:master Aug 3, 2020
@feast-ci-bot
Copy link
Collaborator

@woop: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-redis-cluster 61b60cb link /test test-end-to-end-redis-cluster

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed images versions in Helm charts
2 participants