Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Get job controller deployment for docker compose back #958

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Aug 24, 2020

This reverts commit 5b72335.

What this PR does / why we need it:

To fix load tests we need to have docker compose config sync with master (latest dev) structure.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex changed the title Revert "Revert job controller deployment for docker compose (#957)" Get job controller deployment for docker compose back Aug 24, 2020
@pyalex pyalex merged commit 991b4cd into feast-dev:master Aug 24, 2020
@feast-ci-bot
Copy link
Collaborator

@pyalex: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-redis-cluster 65081e3 link /test test-end-to-end-redis-cluster

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants