Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert old changes and apply new strategy to add pagination support. #4

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

otang
Copy link
Contributor

@otang otang commented Apr 18, 2018

@eddyystop as you alluded to on slack, I feel this is a better solution for adding pagination support. Disable pagination by default for service calls from the loaderFactory.

@eddyystop
Copy link
Collaborator

I agree this is a better solution. It causes the default behavior to return correct results.

One reason, often the main reason, for using pagination is to reduce the load on the database from any one service call. The maximum load imposed by the batchloader can be controlled by its maxBatchSize option.

@eddyystop eddyystop merged commit 128634a into feathersjs-ecosystem:master Apr 18, 2018
@eddyystop
Copy link
Collaborator

Published as v0.3.3

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants