Cookie not getting set

[marshallswain]

Steps to reproduce

Generate an app with the feathers-cli@pre
Add github authentication, use NeDB.
Add a cookie config inside the authentication config:

"cookie": {
  "enabled": true, // whether cookie creation is enabled
  "name": "feathers-jwt", // the cookie name
  "httpOnly": false, // when enabled, prevents the client from reading the cookie.
  "secure": false // whether cookies should only be available over HTTPS
}

Expected behavior

Upon successful response from the server, after the OAuth flow, the cookie should get set.

Actual behavior

The cookie doesn't get set because res.hook doesn't exist here: https://github.com/feathersjs/feathers-authentication/blob/master/src/express/set-cookie.js#L27

I don't see where it is getting set. Do we need to check for this? @ekryski

The only place I see it getting set is here: https://github.com/feathersjs/feathers-authentication-oauth2/blob/master/src/express/handler.js#L28

I don't have a successRedirect setup.

[marshallswain]

Closed in feathersjs-ecosystem/authentication#474