Skip to content
This repository was archived by the owner on Aug 29, 2018. It is now read-only.

Remove typeof 'string' check for secret #9

Closed
jeffijoe opened this issue Dec 22, 2016 · 2 comments · Fixed by #12
Closed

Remove typeof 'string' check for secret #9

jeffijoe opened this issue Dec 22, 2016 · 2 comments · Fixed by #12

Comments

@jeffijoe
Copy link

A secret can also be a buffer (when passed to jsonwebtoken) and the string check will prevent that.

Offending line: https://github.com/feathersjs/feathers-authentication-jwt/blob/master/src/index.js#L43

@daffl
Copy link
Member

daffl commented Dec 23, 2016

Did you try if it works removing this line of code from the code for this package in node_modules?

@jeffijoe
Copy link
Author

Yes, it works with that line removed.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants