Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

Make oauth2 more general #179

Closed
gurisko opened this issue Apr 27, 2016 · 5 comments
Closed

Make oauth2 more general #179

gurisko opened this issue Apr 27, 2016 · 5 comments
Labels
Milestone

Comments

@gurisko
Copy link

gurisko commented Apr 27, 2016

The current implementation is not very general:

  • assuming ${options.provider}Id field in a database
  • updating a user with all data returned by the passport strategy (link)

This could be solved by allowing to specify a provider field in a database and support a custom hooks.

@ekryski
Copy link
Member

ekryski commented Apr 28, 2016

The second issue is now resolved (yet to be released). I agree, any chance you want to put together a PR for allowing to specify a provider field?

@ekryski ekryski added the Task label Apr 28, 2016
@gurisko
Copy link
Author

gurisko commented Apr 28, 2016

@ekryski Definitely. I will look into this during the weekend.

@ekryski
Copy link
Member

ekryski commented May 21, 2016

@gurisko still waiting on that PR 😉 🙏

@ekryski ekryski added this to the 0.8 milestone May 21, 2016
@ekryski ekryski added ready and removed Backlog labels May 21, 2016
@ekryski
Copy link
Member

ekryski commented Jul 19, 2016

This is still on the radar. Steps are being made to make it more general and at a minimum you'll soon be able to extend the service to have your own custom logic without having to rewrite the whole module or all of auth.

@ekryski
Copy link
Member

ekryski commented Oct 26, 2016

This is done and in 0.8-beta. Can be accessed and extended by doing this:

const OAuth2Service = require('feathers-authentication').OAuth2Service

class MyService extends OAuth2Service {

}

app.configure(MyService(options))

It is likely that this is moving to it's own repo https://github.com/feathersjs/feathers-authentication-oauth2

@ekryski ekryski closed this as completed Oct 26, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants