Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

OAuth2 authentication callback failing due to missing property #196

Closed
nyaaao opened this issue May 3, 2016 · 0 comments · Fixed by #197
Closed

OAuth2 authentication callback failing due to missing property #196

nyaaao opened this issue May 3, 2016 · 0 comments · Fixed by #197
Labels

Comments

@nyaaao
Copy link
Contributor

nyaaao commented May 3, 2016

I'm getting and error TypeError: Cannot set property 'accessToken' of undefined in https://github.com/feathersjs/feathers-authentication/blob/master/src/services/oauth2/index.js#L44 probably due to _json property is missing. Looking at other Strategies' implementation I see this in passport-facebook (set here: https://github.com/jaredhanson/passport-facebook/blob/master/lib/strategy.js#L179), but not, for example, in passport-google. My Strategy provider does not set it as well.

Can this be made conditional?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants