Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

Responses hang when token.secret is undefined for local authentication #249

Closed
petermikitsh opened this issue Jul 28, 2016 · 2 comments
Closed

Responses hang when token.secret is undefined for local authentication #249

petermikitsh opened this issue Jul 28, 2016 · 2 comments
Labels
Feature
Milestone
1.0

Comments

@petermikitsh
Copy link
Contributor

petermikitsh commented Jul 28, 2016 •
edited
Loading

If authentication config value token.secret is set to null or undefined, successful local authentication attempts will hang. Unsuccessful authentication attempts will return 401 as expected.

Probably should yell at the developer for improper usage, perhaps with some sort of warning message :)
@ekryski
Copy link
Member

ekryski commented Aug 4, 2016

Coming in the next 0.8 release. 😄 Thanks for reporting @petermikitsh!

@ekryski ekryski added this to the 0.8 milestone Aug 4, 2016
@ekryski ekryski modified the milestones: 0.8, 1.0 Nov 21, 2016
@ekryski
Copy link
Member

ekryski commented Dec 30, 2016

This is now fixed in v1.x. If a token secret is falsey we toss an error on app startup.

@ekryski ekryski closed this as completed Dec 30, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@ekryski @petermikitsh